Hi Geert, On 09/13/2012 07:06 PM, Geert Uytterhoeven wrote: > On Thu, Aug 23, 2012 at 10:37 PM, Florian Tobias Schandinat > <FlorianSchandinat@xxxxxx> wrote: >> On 07/31/2012 04:39 PM, Damien Cassou wrote: >>> From: Damien Cassou <damien.cassou@xxxxxxx> >>> >>> The various devm_ functions allocate memory that is released when a driver >>> detaches. This patch uses these functions for data that is allocated in >>> the probe function of a platform device and is only freed in the remove >>> function. >>> >>> Signed-off-by: Damien Cassou <damien.cassou@xxxxxxx> >> >> Applied. > >>> diff --git a/drivers/video/gbefb.c b/drivers/video/gbefb.c >>> index 7e7b7a9..9b79d38 100644 >>> --- a/drivers/video/gbefb.c >>> +++ b/drivers/video/gbefb.c >>> @@ -1156,7 +1156,8 @@ static int __devinit gbefb_probe(struct platform_device *p_dev) >>> goto out_release_framebuffer; >>> } >>> >>> - gbe = (struct sgi_gbe *) ioremap(GBE_BASE, sizeof(struct sgi_gbe)); >>> + gbe = (struct sgi_gbe *) devm_ioremap(&p_dev->dev, GBE_BASE, >>> + sizeof(struct sgi_gbe)); > > drivers/video/gbefb.c:1159:16: error: implicit declaration of function > 'devm_ioremap' [-Werror=implicit-function-declaration] > drivers/video/gbefb.c:1179:3: error: implicit declaration of function > 'devm_ioremap_nocache' [-Werror=implicit-function-declaration] Thanks for pointing this out. I guess the solution is to replace the include asm/io.h by linux/io.h as Axel Lin did for some other driver in this patch series. @Damien: Can you please do a patch as I suggested and preferable also recheck the other drivers you touched? And it probably would have been a good idea to mention that you didn't compile-test it. I do some compile tests before pushing my branch but that is far from complete due to arch and platform specific drivers. Best regards, Florian Tobias Schandinat > > http://kisskb.ellerman.id.au/kisskb/buildresult/7187731/ > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
