On Wed, Jun 20, 2012 at 3:21 PM, Rajesh Borundia <rajesh.borundia@xxxxxxxxxx> wrote: > _______________________________________ > From: santosh prasad nayak [santoshprasadnayak@xxxxxxxxx] > Sent: Wednesday, June 20, 2012 1:29 PM > To: Dan Carpenter; Rajesh Borundia > Cc: Sony Chacko; netdev; kernel-janitors@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] netxen: Error return off by one in 'netxen_nic_set_pauseparam()'. > > On Wed, Jun 20, 2012 at 1:14 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: >> On Wed, Jun 20, 2012 at 12:57:39PM +0530, santosh nayak wrote: >>> From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx> >>> >>> There are 'NETXEN_NIU_MAX_GBE_PORTS' GBE ports. Port indexing starts >>> from zero. >>> Hence we should also return error for "port == NETXEN_NIU_MAX_GBE_PORTS" >>> >> >> I don't know this code well enough to say if you are right or not, >> but what about for port == NETXEN_NIU_MAX_XG_PORTS a few lines later >> in both functions? > > > I think "for port == NETXEN_NIU_MAX_XG_PORTS" error should be returned. > > > @Rajesh, > > Can you please comment on it ? > > > regards > santosh > >> >> regards, >> dan carpenter >> > > Yes error should be returned for both port == NETXEN_NIU_MAX_XG_PORTS and > port == NETXEN_NIU_MAX_GBE_PORTS. Ok. The current patch is for GBE port. For XG port I will send another patch. regards santosh > > > Rajesh > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
