On Wed, Jun 20, 2012 at 12:57:39PM +0530, santosh nayak wrote: > From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx> > > There are 'NETXEN_NIU_MAX_GBE_PORTS' GBE ports. Port indexing starts > from zero. > Hence we should also return error for "port == NETXEN_NIU_MAX_GBE_PORTS" > So my understanding is that you are guessing on this based on the fact that, "Who counts from 0-4 inclusive?". I can't argue with that logic. Looking some more at NETXEN_NIU_MAX_XG_PORTS. It is used off by one 4 times and it's used correctly 1 time. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
