On Wed, Jun 20, 2012 at 12:57:39PM +0530, santosh nayak wrote: > From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx> > > There are 'NETXEN_NIU_MAX_GBE_PORTS' GBE ports. Port indexing starts > from zero. > Hence we should also return error for "port == NETXEN_NIU_MAX_GBE_PORTS" > I don't know this code well enough to say if you are right or not, but what about for port == NETXEN_NIU_MAX_XG_PORTS a few lines later in both functions? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
