On 2019-11-04 11:27:32 [-0700], Jerry Snitselaar wrote: > On Mon Nov 04 19, Sebastian Andrzej Siewior wrote: > > On 2019-11-04 10:37:09 [-0700], Jerry Snitselaar wrote: > > > It looks like checkpatch is expecting the word commit to precede the hash on the same line. > > > I get no errors with the following: > > > > That would explain it. That is however not what the TIP tree and other > > people do not to mention that reading wise it makes sense to keep the > > word `commit' as part of the sentence and add the hash in the next line. > > > > Yes it reads better. What about the following? > > Added in commit 9e1b74a63f776 ("tpm: add support for nonblocking > operation"), but never actually used it. > > And then add the Fixes: line above the Cc: and Signed-off-by: ? Can please get over with? It is a simple patch. It has simple description. Sebastian