Re: [PATCH] tpm: remove tpm_dev_wq_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon Nov 04 19, Sebastian Andrzej Siewior wrote:
On 2019-11-04 10:37:09 [-0700], Jerry Snitselaar wrote:
It looks like checkpatch is expecting the word commit to precede the hash on the same line.
I get no errors with the following:

That would explain it. That is however not what the TIP tree and other
people do not to mention that reading wise it makes sense to keep the
word `commit' as part of the sentence and add the hash in the next line.


Yes it reads better. What about the following?

Added in commit 9e1b74a63f776 ("tpm: add support for nonblocking
operation"), but never actually used it.

And then add the Fixes: line above the Cc: and Signed-off-by: ?

Added in

  commit 9e1b74a63f776 ("tpm: add support for nonblocking operation")

but never actually used it.

Fixes: 9e1b74a63f776 ("tpm: add support for nonblocking operation")
Cc: Philip Tricca <philip.b.tricca@xxxxxxxxx>
Cc: Tadeusz Struk <tadeusz.struk@xxxxxxxxx>
Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Sebastian





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux