On Mon Nov 04 19, Sebastian Andrzej Siewior wrote:
sorry for that late reply, was traveling…
On 2019-10-28 22:26:37 [+0200], Jarkko Sakkinen wrote:
> OK, so. Gave a relook at this:
>
> This gives checkpatch.pl error:
>
> 0012-tpm-remove-tpm_dev_wq_lock.patch
> -------------------------------------
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9e1b74a63f77 ("tpm: add support for nonblocking operation")'
> #8:
> 9e1b74a63f776 ("tpm: add support for nonblocking operation")
>
> total: 1 errors, 0 warnings, 7 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Please send me a new patch with a legit fixes line. It is a fix to
> regression even if it is a cosmetic one.
>
> I'll drop the current patch from my tree and apply a new one once
> I get it from you.
Can you please explain what is wrong with that one? It is exactly as
suggested by the error line.
> Thanks.
>
> /Jarkko
AFAIK cc stable triggers stable backport, not fixes line alone (not
100% sure about this though). Anyway even my original response was
meant to this patch I recall now that I bumped into that checkpatch
error.
The cc: for stable and fixes are high indicators for it to be
considered. These days even a few keywords in the commit message might
let Sasha's script decide to pick/suggest a patch for stable.
/Jarkko
Sebastian
It looks like checkpatch is expecting the word commit to precede the hash on the same line.
I get no errors with the following:
Added in
commit 9e1b74a63f776 ("tpm: add support for nonblocking operation")
but never actually used it.
Fixes: 9e1b74a63f776 ("tpm: add support for nonblocking operation")
Cc: Philip Tricca <philip.b.tricca@xxxxxxxxx>
Cc: Tadeusz Struk <tadeusz.struk@xxxxxxxxx>
Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
