Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 於 2023年12月28日 週四 下午6:36寫道： > > On 27/12/2023 06:35, Allen_Lin wrote: > > Add the HX83102j touchscreen device tree bindings documents. > > > > Signed-off-by: Allen_Lin <allencl_lin@xxxxxxxxxxx> > > --- > > Where is the changelog? There is no cover letter attached, so changelog > is supposed to be here. There were several comments, so does it mean you > ignored them? > Cover letter is not in this mail but in the mail with this title "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen" Hi, This driver implements for Himax HID touchscreen HX83102j. Using SPI interface to receive/send HID packets. Patchs notes as below 1. Add the Maintainer and devicetree bindings document for driver 2. Add the driver code and modify Kconfig/Makefile to support the driver change in v2 : - Fix kernel test robot build warnings. change in v3 : - Modify code according to review suggesions. Thanks. Allen_Lin (2): dt-bindings: input: Add Himax HX83102J touchscreen Input: Add Himax HX83102J touchscreen driver .../bindings/input/himax,hx83102j.yaml | 65 + MAINTAINERS | 7 + drivers/hid/Kconfig | 8 + drivers/hid/Makefile | 2 + drivers/hid/hid-himax-83102j.c | 1096 +++++++++++++++++ drivers/hid/hid-himax-83102j.h | 202 +++ 6 files changed, 1380 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/himax,hx83102j.yaml create mode 100644 drivers/hid/hid-himax-83102j.c create mode 100644 drivers/hid/hid-himax-83102j.h -- 2.34.1 > > > .../bindings/input/himax,hx83102j.yaml | 65 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/himax,hx83102j.yaml b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > new file mode 100644 > > index 000000000000..872b478c5753 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/input/himax,hx83102j.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Himax hx83102j touchscreen > > + > > ... > > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + hid-himax-spi@0 { > > Still not the name I asked - it should be generic, like touchscreen. > I will fix it, thanks for your review. if driver code needs to be modified, i will fix it together. > Best regards, > Krzysztof > Best regards Allen
