On 27/12/2023 06:35, Allen_Lin wrote: > Add the HX83102j touchscreen device tree bindings documents. > > Signed-off-by: Allen_Lin <allencl_lin@xxxxxxxxxxx> > --- Where is the changelog? There is no cover letter attached, so changelog is supposed to be here. There were several comments, so does it mean you ignored them? > .../bindings/input/himax,hx83102j.yaml | 65 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > diff --git a/Documentation/devicetree/bindings/input/himax,hx83102j.yaml b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > new file mode 100644 > index 000000000000..872b478c5753 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/himax,hx83102j.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Himax hx83102j touchscreen > + ... > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + hid-himax-spi@0 { Still not the name I asked - it should be generic, like touchscreen. Best regards, Krzysztof
