On Fri, 28 Nov 2008, Łukasz Lubojański wrote: > > It seems the protocol resembles more the hid-lg2ff one. The differences > > are the additional 0xfa 0xfe 0x0 report sent to the device, and the > > missing 0xf3 stop command. > Yep - different reports are send in case of Pantherlord and GreenAsia > 0x12 - It could be implemented in it but it will require checking what > hardware is used and send different reports. OK, so as the reports are not really identical, and in the future we might discover that there are many more other Greenasia devices which require a slightly different handling as well, I would rather prefer to have it as a separate driver, to avoid additions of here-and-there device-specific quirks to random places in the code. That's exactly what we are trying to avoid with the HID bus approach in the first place. So I think separate driver is fine. Thanks to both of you. -- Jiri Kosina SUSE Labs
