On Fri, 28 Nov 2008, Łukasz Lubojański wrote: > > Could you please rebase your patch on top of current state of Linus' > > kernel tree for 2.6.28-rc? Then the code could be reviewed and I'll merge > > it through my tree. > > For inspiration, you can look into > > > > drivers/hid/hid-pl.c > > > > That driver even contains support for some Greenasia device ... (0x0003). > I have rewriten the code for 2.6.28-rc6 and after testing and checking > it with checkpatch I will send it again. Great, thanks. > Anyway I know that pantherlord code is also supporting greenasia devices > (first code was also mostly taken from that) - and I'm still don't know > if I'm dooing right naming my part "greenasia" - because some people > could get confused. It could also happen that someone else will > implement other greenasia device and this will make another confusion. The question is how much the protocol that is used by your device differs from the one that is already implemented in hid-pl.c? Would it make sense to have these two implementations in the same driver, or is the protocol just completely different? > ps. Do I need to ask Manta and SpeedLink for permission of using they > company and product names in descriptions ? I seriously hope you don't have to, we will all be violating this all the time. But I am not a lawyer, of course :) Thanks, -- Jiri Kosina SUSE Labs
