> On Wed, 26 Nov 2008, Łukasz Lubojański wrote: > > I have implemented Force Feedback driver for another "GreeAsia" based > > device (0e8f:0012 "GreenAsia Inc. USB Joystick "). The > > functionality was tested with MANTA Warior MM816 and SpeedLink Strike2 > > SL-6635 and fftest software - everything seems to work right. > > Is there anyone able to check the code say if this good enough to include > > it into official kernel ? > > Hi, > > thanks for doing this work. The HID code has been redone for 2.6.28, and > HID generic layer now provides proper kernel bus, to which the specialized > drivers should register properly. This has been done in order to keep the > code clean and maintainable, as adding all the quirks during the past > years started turning the HID code into unmaintainable mess. > > Could you please rebase your patch on top of current state of Linus' > kernel tree for 2.6.28-rc? Then the code could be reviewed and I'll merge > it through my tree. > For inspiration, you can look into > > drivers/hid/hid-pl.c > > That driver even contains support for some Greenasia device ... (0x0003). > > Thanks! I have rewriten the code for 2.6.28-rc6 and after testing and checking it with checkpatch I will send it again. Anyway I know that pantherlord code is also supporting greenasia devices (first code was also mostly taken from that) - and I'm still don't know if I'm dooing right naming my part "greenasia" - because some people could get confused. It could also happen that someone else will implement other greenasia device and this will make another confusion. Maybe warrior_strike will be better name ? Of course there will be still noted in description that it is supporting other GreenAsia 0x12 based devices. ps. Do I need to ask Manta and SpeedLink for permission of using they company and product names in descriptions ? regards Lukasz Lubojanski -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
