Hello, thanks for the confirmation, Jonathan. Then, it's good for me. Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx> Thanks, JB ________________________________________ From: Jonathan Cameron <jic23@xxxxxxxxxx> Sent: Saturday, November 23, 2024 16:33 To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx> Cc: Frank Li <Frank.Li@xxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx <devicetree@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; Han Xu <han.xu@xxxxxxx> Subject: Re: [PATCH v2 2/2] iio: gyro: Add support for iam20380 sensor This Message Is From an External Sender This message came from outside your organization. On Wed, 20 Nov 2024 11:05:23 +0000 Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx> wrote: > Hello, > > overall looks good, but I've got one concern. > > The gyro bits used for scan mask are the same than other chips, meaning bits 4, 5, 6, and timestamp is bit 7, and these are the only bits since the chip is gyro only. Usually scan mask bits start at 0. I don't know if starting from 4 will work or not. > > Jonathan, > do you know if this can be an issue? Shouldn't be an issue. There are various drivers that do this. https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.12/source/drivers/iio/imu/adis16400.c*L821__;Iw!!FtrhtPsWDhZ6tw!BUKGdZqx3SyrRUYhJqLMYen_msXNlBLk9L5OacejstVPtdMCSpltGpI8mpXdrFctK2l-lAmLQE4lpEXq16X-Up4$[elixir[.]bootlin[.]com] was one example that I remembered as IIRC that driver was the motivation for these being sparse. Normally we just pack them together because it feels neat and tidy plus for high channel count devices means we can still use a single unsigned long for the channel bitmaps. It's not a requirement as such... Jonathan > > Thanks, > JB > > ________________________________________ > From: Frank Li <Frank.Li@xxxxxxx> > Sent: Friday, November 15, 2024 23:37 > To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx <devicetree@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; Frank Li <Frank.Li@xxxxxxx>; Han Xu <han.xu@xxxxxxx> > Subject: [PATCH v2 2/2] iio: gyro: Add support for iam20380 sensor > > This Message Is From an External Sender > This message came from outside your organization. > > From: Han Xu <han.xu@xxxxxxx> > > Add support for the Invensense IAM20380 sensor to the MPU6050 driver. It is > similar to the IAM20680. But IAM20380 only supports gyro and WHOAMI > register data is difference. > > Signed-off-by: Han Xu <han.xu@xxxxxxx> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 25 +++++++++++++++++++++++++ > drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 6 ++++++ > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 2 ++ > drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 5 +++++ > 4 files changed, 38 insertions(+) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > index 40271352b02cf..a7535cbc214e9 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > @@ -277,6 +277,14 @@ static const struct inv_mpu6050_hw hw_info[] = { > .temp = {INV_ICM20608_TEMP_OFFSET, INV_ICM20608_TEMP_SCALE}, > .startup_time = {INV_ICM20690_GYRO_STARTUP_TIME, INV_ICM20690_ACCEL_STARTUP_TIME}, > }, > + { .whoami = INV_IAM20380_WHOAMI_VALUE, > + .name = "IAM20380", > + .reg = ®_set_6500, > + .config = &chip_config_6500, > + .fifo_size = 512, > + .temp = {INV_ICM20608_TEMP_OFFSET, INV_ICM20608_TEMP_SCALE}, > + .startup_time = {INV_MPU6500_GYRO_STARTUP_TIME, INV_MPU6500_ACCEL_STARTUP_TIME}, > + }, > { > .whoami = INV_IAM20680_WHOAMI_VALUE, > .name = "IAM20680", > @@ -1519,6 +1527,14 @@ static const struct iio_chan_spec inv_mpu6050_channels[] = { > INV_MPU6050_CHAN(IIO_ACCEL, IIO_MOD_Z, INV_MPU6050_SCAN_ACCL_Z), > }; > > +static const struct iio_chan_spec inv_iam20380_channels[] = { > + IIO_CHAN_SOFT_TIMESTAMP(INV_MPU6050_SCAN_TIMESTAMP), > + > + INV_MPU6050_CHAN(IIO_ANGL_VEL, IIO_MOD_X, INV_MPU6050_SCAN_GYRO_X), > + INV_MPU6050_CHAN(IIO_ANGL_VEL, IIO_MOD_Y, INV_MPU6050_SCAN_GYRO_Y), > + INV_MPU6050_CHAN(IIO_ANGL_VEL, IIO_MOD_Z, INV_MPU6050_SCAN_GYRO_Z), > +}; > + > static const struct iio_chan_spec inv_mpu6500_channels[] = { > IIO_CHAN_SOFT_TIMESTAMP(INV_MPU6050_SCAN_TIMESTAMP), > > @@ -1623,6 +1639,10 @@ static const struct iio_chan_spec inv_mpu9250_channels[] = { > | BIT(INV_MPU9X50_SCAN_MAGN_Y) \ > | BIT(INV_MPU9X50_SCAN_MAGN_Z)) > > +static const unsigned long inv_iam20380_scan_masks[] = { > + INV_MPU6050_SCAN_MASK_3AXIS_GYRO, > +}; > + > static const unsigned long inv_mpu9x50_scan_masks[] = { > /* 3-axis accel */ > INV_MPU6050_SCAN_MASK_3AXIS_ACCEL, > @@ -2026,6 +2046,11 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > indio_dev->num_channels = ARRAY_SIZE(inv_mpu9250_channels); > indio_dev->available_scan_masks = inv_mpu9x50_scan_masks; > break; > + case INV_IAM20380: > + indio_dev->channels = inv_iam20380_channels; > + indio_dev->num_channels = ARRAY_SIZE(inv_iam20380_channels); > + indio_dev->available_scan_masks = inv_iam20380_scan_masks; > + break; > case INV_ICM20600: > case INV_ICM20602: > indio_dev->channels = inv_mpu6500_channels; > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c > index 7a5926ba6b97d..62f7d16c2ddcb 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c > @@ -34,6 +34,7 @@ static bool inv_mpu_i2c_aux_bus(struct device *dev) > case INV_ICM20689: > case INV_ICM20600: > case INV_ICM20602: > + case INV_IAM20380: > case INV_IAM20680: > /* no i2c auxiliary bus on the chip */ > return false; > @@ -187,6 +188,7 @@ static const struct i2c_device_id inv_mpu_id[] = { > {"icm20600", INV_ICM20600}, > {"icm20602", INV_ICM20602}, > {"icm20690", INV_ICM20690}, > + {"iam20380", INV_IAM20380}, > {"iam20680", INV_IAM20680}, > {"iam20680hp", INV_IAM20680HP}, > {"iam20680ht", INV_IAM20680HT}, > @@ -252,6 +254,10 @@ static const struct of_device_id inv_of_match[] = { > .compatible = "invensense,icm20690", > .data = (void *)INV_ICM20690 > }, > + { > + .compatible = "invensense,iam20380", > + .data = (void *)INV_IAM20380 > + }, > { > .compatible = "invensense,iam20680", > .data = (void *)INV_IAM20680 > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > index a6862cf426396..211901f8b8eb6 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > @@ -84,6 +84,7 @@ enum inv_devices { > INV_ICM20600, > INV_ICM20602, > INV_ICM20690, > + INV_IAM20380, > INV_IAM20680, > INV_IAM20680HP, > INV_IAM20680HT, > @@ -425,6 +426,7 @@ struct inv_mpu6050_state { > #define INV_ICM20600_WHOAMI_VALUE 0x11 > #define INV_ICM20602_WHOAMI_VALUE 0x12 > #define INV_ICM20690_WHOAMI_VALUE 0x20 > +#define INV_IAM20380_WHOAMI_VALUE 0xB5 > #define INV_IAM20680_WHOAMI_VALUE 0xA9 > #define INV_IAM20680HP_WHOAMI_VALUE 0xF8 > #define INV_IAM20680HT_WHOAMI_VALUE 0xFA > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c > index e6a291fcda958..cd54e9dbf99ce 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c > @@ -79,6 +79,7 @@ static const struct spi_device_id inv_mpu_id[] = { > {"icm20600", INV_ICM20600}, > {"icm20602", INV_ICM20602}, > {"icm20690", INV_ICM20690}, > + {"iam20380", INV_IAM20380}, > {"iam20680", INV_IAM20680}, > {"iam20680hp", INV_IAM20680HP}, > {"iam20680ht", INV_IAM20680HT}, > @@ -140,6 +141,10 @@ static const struct of_device_id inv_of_match[] = { > .compatible = "invensense,icm20690", > .data = (void *)INV_ICM20690 > }, > + { > + .compatible = "invensense,iam20380", > + .data = (void *)INV_IAM20380 > + }, > { > .compatible = "invensense,iam20680", > .data = (void *)INV_IAM20680 >
