Re: [PATCH 00/15] IIO: use irq_get_trigger_type() instead of opencoding.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 01, 2024 at 02:59:35PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> Andy pointed out in a review that there is an irq_get_trigger_type()
> helper that first gets the irq data then extracts the type from it.
> This saves on opencoding those two steps when the irq data isn't used
> for anything else.
> 
> Update all the sites this pattern occurs in IIO to use the helper.
> In a few cases there will be a slightly different error message is
> somehow there is a valid irq number passed to this call and it doesn't
> have the data associated with it.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

There are some nit-picks, up to you how to proceed with them (only one seems
better to address is where the reversed xmas tree ordering is broken).

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux