On Mon, 2 Sep 2024 14:49:19 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Sun, Sep 01, 2024 at 02:59:35PM +0100, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Andy pointed out in a review that there is an irq_get_trigger_type() > > helper that first gets the irq data then extracts the type from it. > > This saves on opencoding those two steps when the irq data isn't used > > for anything else. > > > > Update all the sites this pattern occurs in IIO to use the helper. > > In a few cases there will be a slightly different error message is > > somehow there is a valid irq number passed to this call and it doesn't > > have the data associated with it. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > There are some nit-picks, up to you how to proceed with them (only one seems > better to address is where the reversed xmas tree ordering is broken). > I made the changes suggested. Applied to the togreg branch of iio.git. I think these will probably wait for next cycle now given timing. Jonathan
