On Sat, Feb 17, 2024 at 04:42:34PM +0000, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Sorry for the rapid resend, Andy noticed I'd messed up creating the v3 patch > set with some updates committed in the wrong patch. > > Since v3: The updates to alignment of device_for_each_child_node_scopd() were > in the wrong patch. Move them to patch 4 where they should always > have been. (thanks Andy!) > > Since v2: Thanks to Sakari and Andy for reviews. > - New first patch moving fwnode_handle_put() into property.h > - Tweak alignment in the loop macro > - Pick up tags. > - scopd -> scoped typo fix in some patch descriptions. > > As can be seen by the examples from IIO that follow this can save > a reasonable amount of complexity and boiler plate code, often enabling > additional cleanups in related code such as use of > return dev_err_probe(). > > Given we are now fairly late in the cycle, I'd expect to take this > through the IIO tree and we can make use of it elsewhere next cycle. > > Note I don't have the hardware so this is compile tested only. > Hence I'd appreciate some Tested-by tags if anyone can poke one of the > effected drivers. > > Julia Lawal has posted some nice coccinelle magic for the DT equivalents. > Referenced from that cover letter. Similar may help us convert more > drivers to use this new approach, but often hand tweaking can take > additional advantage of other cleanup.h based magic, or things like > return dev_err_probe(). > https://lore.kernel.org/all/20240211174237.182947-1-jic23@xxxxxxxxxx/ It seems you are got all necessary tags to go. I commented with some side notes that may be addressed later on. Up to you. -- With Best Regards, Andy Shevchenko
