On Wed, Feb 14, 2024 at 12:39 AM Jonathan LoBue <jlobue10@xxxxxxxxx> wrote: > > This patch adds the ACPI match table for ASUS ROG ALLY to load the bmi323 > driver with an ACPI match of "BOSC0200". With the remarks below, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> (carry the tag if you send a new version) ... The below comment... > +/* > + * The "BOSC0200" ACPI identifier used here in the bmi323 driver is not s/ACPI// s/in the bmi323 driver// > + * unique to bmi323 devices. The same "BOSC0200" identifier is found in > + * devices using the bmc150 chip. This creates a conflict with duplicate > + * ACPI identifiers which multiple drivers want to use. If a non-bmi323 > + * device starts to load with this "BOSC0200" ACPI match here, then the > + * chip id check portion should fail and the driver should relinquish the > + * device. This seems different wording to the other one. Have you looked at the code if it's indeed the case? Because we may not rely on the module load order. > If and when a different driver (such as bmc150) starts to load > + * with the "BOSC0200" ACPI match, a short reset should ensure that the > + * device is not in a bad state during that driver initialization. This > + * device reset does occur in both the bmi323 and bmc150 init sequences. > + */ > + > +static const struct acpi_device_id bmi323_acpi_match[] = { ...should be here (and indented accordingly). > + { "BOSC0200" }, > + { } > +}; -- With Best Regards, Andy Shevchenko