On Wed, Feb 14, 2024 at 12:38 AM Jonathan LoBue <jlobue10@xxxxxxxxx> wrote:
>
> This patch adds a description of the duplicate ACPI identifier issue
> between devices using bmc150 and bmi323.
With the remarks below,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
(carry the tag if you send a new version)
...
> Comment describing the duplicate ACPI identifier issue has been added
> before the "BOSC0200" entry here.
Hmm...
...
> +/*
> + * The "BOSC0200" ACPI identifier used here in the bmc150 driver is not
s/ACPI//
s/in the bmc150 driver//
> + * unique to devices using bmc150. The same "BOSC0200" identifier is found
> + * in the ACPI tables of the ASUS ROG ALLY and Ayaneo AIR Plus which both
> + * use a Bosch BMI323 chip. This creates a conflict with duplicate ACPI
> + * identifiers which multiple drivers want to use. Fortunately, when the
> + * bmc150 driver starts to load on the ASUS ROG ALLY, the chip id check
> + * portion fails (correctly) and a dmesg output similar to this:
> + * "bmc150_accel_i2c i2c-BOSC0200:00: Invalid chip 0" can be seen.
> + * This allows the bmi323 driver to take over for ASUS ROG ALLY.
> + */
> +
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id bmc150_acpi_dual_accel_ids[] = {
...it should be here. But don't resend, let's Jonathan to decide in
case he won't amend this when applying.
> {"BOSC0200"},
--
With Best Regards,
Andy Shevchenko
