On Tue, Feb 13, 2024 at 7:14 PM Jonathan LoBue <jlobue10@xxxxxxxxx> wrote: > On Tuesday, February 13, 2024 2:49:24 AM PST Andy Shevchenko wrote: > > I'm lost. You sent a lot of patches / patch series all of which are v1. Can you: > > - use versioning (`git format-patch -v<X>...`, where <X> is a plain > > version number) > > - add a changelog here (after the cutter '---' line) to explain the > > history of the changes > > ? > > Yes, I will do this. The changes so far included dropping the no longer > necessary DMI quirks portion in the bmc150 driver. I understand from > your comment that we want to add a comment in the bmc150 driver though > to explain what is going on with duplicate ACPI identifiers in different > drivers. I will add a similar comment in the bmi323 driver. The changes > so far also included the fixes that you requested earlier in bmi323: > dropping the duplicate header include entry (included already in other > header file), removing the unnecessary comma in the ACPI match table > portion, and removing the ACPI_PTR when invoking the ACPI match table. > > > Since there is a collision please add a big comment in _both_ drivers > > before such ID to explain what's going on. > > I will do this and add a changelog after the cutter as requested. Since there > are some changes from my initial submission attempt and with the additional > requested comments, is v2 going to be okay to use so there's no ambiguity > about which patch version to use? Sounds good as we seem never to have seen v2 on the topic. > I will attach the version label with > git format-patch as requested. Thanks. -- With Best Regards, Andy Shevchenko
