Re: [PATCH v1] iio: imu: bmi323: Add and enable ACPI Match Table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 13, 2024 at 4:39 AM Jonathan LoBue <jlobue10@xxxxxxxxx> wrote:
>
> This patch adds the ACPI match table for ASUS ROG ALLY to load the bmi323
> driver with an ACPI match of "BOSC0200".

> ---

I'm lost. You sent a lot of patches / patch series all of which are v1. Can you:
- use versioning (`git format-patch -v<X>...`, where <X> is a plain
version number)
- add a changelog here (after the cutter '---' line) to explain the
history of the changes
?

...

> +static const struct acpi_device_id bmi323_acpi_match[] = {
> +       { "BOSC0200" },
> +       { }
> +};

Since there is a collision please add a big comment in _both_ drivers
before such ID to explain what's going on.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux