From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> Since RFC: - Provide a for_each_available_child_of_node_scoped() variant and use that whenever we aren't specifically trying to include disabled nodes. - Fix the for_each_child_of_node_scoped() to not use a mix of _available_ and other calls. - Include a few more examples. The last one is there to show that not all uses of the __free(device_node) call are due to the loops. Thanks to Julia Lawal who also posted coccinelle for both types (loop and non loop cases) https://lore.kernel.org/all/alpine.DEB.2.22.394.2401312234250.3245@hadrien/ https://lore.kernel.org/all/alpine.DEB.2.22.394.2401291455430.8649@hadrien/ The cover letter of the RFC includes information on the various approaches considered. https://lore.kernel.org/all/20240128160542.178315-1-jic23@xxxxxxxxxx/ Whilst these macros profduce nice reductions in complexity the loops still have the unfortunate side effect of hiding the local declaration of a struct device_node * which is then used inside the loop. Julia suggested making that a little more visible via #define for_each_child_of_node_scoped(parent, struct device_node *, child) but in discussion we both expressed that this doesn't really make things all that clear either so I haven't adopted this suggestion. If the responses to this series are positive I can put the first few patches on an immutable branch, allowing rapid adoption in other trees if people want to move quickly. If not we can wait for next cycle and just take this infrastructure through the IIO tree ready for the 6.9 merge cycle. I'll be optimistic that we are converging and send out an equivalent series for fwnode_handle / property.h to replace the previous proposal: https://lore.kernel.org/all/20240114172009.179893-1-jic23@xxxxxxxxxx/ Jonathan Cameron (8): of: Add cleanup.h based auto release via __free(device_node) markings. of: Introduce for_each_*_child_of_node_scoped() to automate of_node_put() handling of: unittest: Use for_each_child_of_node_scoped() iio: adc: fsl-imx25-gcq: Use for_each_available_child_node_scoped() iio: adc: rcar-gyroadc: use for_each_available_child_node_scoped() iio: adc: ad7124: Use for_each_available_child_of_node_scoped() iio: adc: ad7292: Use for_each_available_child_of_node_scoped() iio: adc: adi-axi-adc: Use __free(device_node) and guard(mutex) drivers/iio/adc/ad7124.c | 20 ++++++-------------- drivers/iio/adc/ad7292.c | 7 ++----- drivers/iio/adc/adi-axi-adc.c | 16 ++++------------ drivers/iio/adc/fsl-imx25-gcq.c | 13 +++---------- drivers/iio/adc/rcar-gyroadc.c | 21 ++++++--------------- drivers/of/unittest.c | 11 +++-------- include/linux/of.h | 15 +++++++++++++++ 7 files changed, 39 insertions(+), 64 deletions(-) -- 2.43.1
