Re: [PATCH 2/2] iio: imu: bmi323: Add and enable ACPI Match Table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 11, 2024 at 12:34 AM Jonathan LoBue <jlobue10@xxxxxxxxx> wrote:
>
> From c65d1ef44d749958f02d2b9a50a0e788b4497854 Mon Sep 17 00:00:00 2001
> From: Jonathan LoBue <jlobue10@xxxxxxxxx>
> Date: Sat, 10 Feb 2024 12:31:54 -0800
> Subject: [PATCH 2/2] iio: imu: bmi323: Add and enable ACPI Match Table

Something went wrong with the email body.

> This patch adds the ACPI match table for ASUS ROG ALLY to load the bmi323
> driver with an ACPI match of "BOSC0200".

...

> +#include <linux/acpi.h>

It's not used. You don't need it as the proper one is already included...

>  #include <linux/i2c.h>
>  #include <linux/mod_devicetable.h>

...here ^^^.

>  #include <linux/module.h>

...

> +static const struct acpi_device_id bmi323_acpi_match[] = {
> +       {"BOSC0200"},
> +       { },

No comma for the terminator line.

> +};

...

> +               .acpi_match_table = ACPI_PTR(bmi323_acpi_match),

No ACPI_PTR() in new code. It's more problematic than helpful.

...


Above for your information for the future contributions, as I said in
the other patch comment, I think the better approach is to enumerate
from an external driver under the PDx86 realm.


-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux