On Tue, 3 Jan 2023 19:43:55 +0800 haibo.chen@xxxxxxx wrote: > From: Haibo Chen <haibo.chen@xxxxxxx> > > V5: > -For ADC driver, use dev_err_probe() to replace dev_err() in dev_err_probe(). > -Add imx93_adc_power_down() in the probe error path. > -Re-order the function in imx93_adc_remove(), make them inverse in probe(). > -Remove the pm_runtime_get_sync(dev) in imx93_adc_remove(), because this driver > enable the pm_runtime autosuspend feature, and config the delay as 50ms. So when > called imx93_adc_remove(), this device still in runtime resume state, no need to > force resume the device back. I don't follow this point. Perhaps talk me through in more detail on why the device will be in a runtime resumed state when ever we hit remove? > -no changes for binding doc and dts. > > V4: > For ADC driver, re-define the ADC status show the relation to specific register bit. > Redo the imx93_adc_remove(), change the return error sequence in imx93_adc_read_raw(), > and use a direct string for indio_dev->name. > For dt-bings, change the commit title and add maintainer's reviewed by tag > For dts, no change. > > V3: > For dt-bings, add some change according to review comments, and pass dt_binding_check. > For dts, add #io-channel-cells = <1>; to pass dtbs_check > For ADC driver, no change. > > V2: > For ADC driver, add change according to matainer's commets. > > Haibo Chen (3): > iio: adc: add imx93 adc support > dt-bindings: iio: adc: Add NXP IMX93 ADC > arm64: dts: imx93: add ADC support > > .../bindings/iio/adc/nxp,imx93-adc.yaml | 81 +++ > MAINTAINERS | 4 +- > .../boot/dts/freescale/imx93-11x11-evk.dts | 12 + > arch/arm64/boot/dts/freescale/imx93.dtsi | 13 + > drivers/iio/adc/Kconfig | 10 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/imx93_adc.c | 477 ++++++++++++++++++ > 7 files changed, 597 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > create mode 100644 drivers/iio/adc/imx93_adc.c >
