On Mon, 20 Jun 2022 17:42:36 +0100 Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > On Mon, 20 Jun 2022 01:00:23 +0200 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > On Sun, Jun 19, 2022 at 8:59 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > > > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > > > I2C does not require DMA safe buffers so there is no need to ensure > > > the buffers are in their own cacheline. Hence simplify things by > > > using a local variable instead of embedding the buffer in the chip > > > info structure. > > > > ... > > > > > sizeof(chip->data), > > > chip->data); > > > > How will these compile? Or am I missing something? > > Nope. Something went wrong in the rebase. I should have rechecked > build patch by patch. Later on, this code is factored out, so I guess > that fixed up the build issue. > > Will check properly for v3. :( yikes rebase went very wrong. Anyhow, will fix up. Turns out I as being an idiot and building with the roadtest makefile which doesn't actually enable this driver until the last patch. Jonathan > > > > > > > - > > > if (ret < 0) > > > goto out; > > > > > > - *val = get_unaligned_be24(chip->data) - 0x800000; > > > + *val = get_unaligned_be24(data) - 0x800000; > > >
