On Wed, Jun 15, 2022 at 02:43:27PM +0200, Andy Shevchenko wrote: > On Wed, Jun 15, 2022 at 2:19 PM William Breathitt Gray > > On Wed, Jun 15, 2022 at 02:00:26PM +0200, Andy Shevchenko wrote: > > > I just realized that this driver is for the old PC104 (like?) hardware > > > that most likely uses IO ports, I don't remember if we have support > > > for IO ports in regmap (MMIO -- yes for sure). > > Hmm, I don't see IO ports mentioned in include/linux/regmap.h, so I > > don't think the regmap API directly supports it (maybe someone familiar > > with regmap knows). Although we do get a virtual mapping cookie via > > ioport_map() in this driver, I don't know if we can pass that to the > > regmap functions and have it actually work. > The problem is with accessors which are inconsistent in regmap MMIO > implementation. I think it should be converted to use > ioreadXX()/iowriteXX() in all cases (currently only BE cases use > them). Another variant is to provide read*_be() / write*_be() for all > architectures, replace corresponding ops in regmap MMIO and introduce > regmap IO with inX()/outX. The former seems to me the best option, > while the latter is cleaner. I don't know what driver this is, but yes someone would have to add ioport support to use them with regmap.
Attachment:
signature.asc
Description: PGP signature
