On Wed, Jun 15, 2022 at 1:55 PM William Breathitt Gray <william.gray@xxxxxxxxxx> wrote: > On Wed, Jun 15, 2022 at 11:44:54AM +0200, Andy Shevchenko wrote: > > On Mon, Jun 6, 2022 at 4:27 PM William Breathitt Gray > > <william.gray@xxxxxxxxxx> wrote: > > > > > > Reduce magic numbers and improve code readability by implementing and > > > utilizing named register data structures. > > > > Can we consider using regmap APIs instead? > The regmap API may be more appropriate here. I'll investigate and see if > I can convert this over to it. I just realized that this driver is for the old PC104 (like?) hardware that most likely uses IO ports, I don't remember if we have support for IO ports in regmap (MMIO -- yes for sure). -- With Best Regards, Andy Shevchenko
