Hello Mark, > -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Friday, October 1, 2021 5:20 AM > To: Denis CIOCCA <denis.ciocca@xxxxxx> > Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen > <lars@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] iio: st_pressure_spi: Add missing entries SPI to device > ID table > > On Thu, Sep 30, 2021 at 06:35:23PM +0000, Denis CIOCCA wrote: > > > I am not very familiar with how much the kernel would like to keep > 'probing id' consistent. I perfectly understand the value of doing this > (maintain ID compatibility) but I also see increase confusion in maintaining > half in a way and half in another. > > The goal is not to maintain compatibility, the goal is to be able to > load the driver as a module on DT systems. For historical reasons SPI > uses the platform device IDs to load modules bound with DT, if there is > no platform ID for a DT ID then userspace won't be able to find and load > the module. Ok now it is clear. I wasn't aware of that. In this case it is good to me (I didn't do any testing). > > > I personally think that we should drop the '-press' thing for all the devices > since they all are single-chip (meaning that the name used identify > univocally that is a pressure sensor). > > The DT bindings are an ABI, you can't really remove compatibles only > deprecate them. Yeah I guessed this was the case. > > > If you think that compatibility is more important here, I think the patch is > fine but this should be done in the i2c part as well so that it's at least > congruent withing the driver. > > I2C doesn't have this issue with modaliases so it's not an issue there. Clear. > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply to.
