Re: [PATCH] iio: st_pressure_spi: Add missing entries SPI to device ID table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 27 Sep 2021 14:41:53 +0100
Mark Brown <broonie@xxxxxxxxxx> wrote:

> Currently autoloading for SPI devices does not use the DT ID table, it uses
> SPI modalises. Supporting OF modalises is going to be difficult if not
> impractical, an attempt was made but has been reverted, so ensure that
> module autoloading works for this driver by adding SPI IDs for parts that
> only have a compatible listed.
> 
> Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Whilst these IDs are deprecated, we should at least be consistent that they either
work or not rather than current situation.

+CC Denis as driver author.  I'll let it sit on list a little longer so Denis can
take a look.

Thanks

Jonathan

> ---
>  drivers/iio/pressure/st_pressure_spi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/iio/pressure/st_pressure_spi.c b/drivers/iio/pressure/st_pressure_spi.c
> index 9b2523c5bc94..d6fc954e28f8 100644
> --- a/drivers/iio/pressure/st_pressure_spi.c
> +++ b/drivers/iio/pressure/st_pressure_spi.c
> @@ -97,6 +97,10 @@ static const struct spi_device_id st_press_id_table[] = {
>  	{ LPS33HW_PRESS_DEV_NAME },
>  	{ LPS35HW_PRESS_DEV_NAME },
>  	{ LPS22HH_PRESS_DEV_NAME },
> +	{ "lps001wp-press" },
> +	{ "lps25h-press", },
> +	{ "lps331ap-press" },
> +	{ "lps22hb-press" },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(spi, st_press_id_table);




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux