On Thu, Jun 10, 2021 at 3:24 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote: > > Right now all the device IDs are listed in seemingly random order, > make this consistent by ordering those alphabetically. Also, order > bmc150_accel_chip_info_tbl by chip ID for the same reason. Thanks! My comments below, after addressing them, Reviewed-by: Andy Shevchenko <andy.shevhcenko@xxxxxxxxx> ... > select BMC150_ACCEL_SPI if SPI > help > Say yes here to build support for the following Bosch accelerometers: > - BMC150, BMI055, BMA250E, BMA222E, BMA255, BMA280. > + BMA222, BMA222E, BMA250E, BMA255, BMA280, BMC150, BMI055. Thanks! > - This is a combo module with both accelerometer and magnetometer. > + BMC150 is a combo module with both accelerometer and magnetometer. BMC150 is only one from the list. Previous message applies to all listed components, so is this not true anymore for the rest? Or all the rest is not a combo? Please, clarify that in the commit message, or if this is a wrong change, drop it. > This driver is only implementing accelerometer part, which has > its own address and register map. -- With Best Regards, Andy Shevchenko
