On Thu, Jun 10, 2021 at 03:45:17PM +0300, Andy Shevchenko wrote: > On Thu, Jun 10, 2021 at 3:24 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote: > > > > The chips supported by the bmc150-accel driver are clearly documented > > in Kconfig, in the bmc150_accel_chip_info_tbl as well as in all the > > device ID tables in the I2C/SPI drivers. It's easy to forget to update > > the lists in the file header. Drop those entirely to reduce the amount > > of changes required to add new chip variants. > > > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > > --- > > New patch in v2. Originally I tried to reorder those too but then it > > caused conflicts in all my following patches so I'm not convinced > > it's worth to try and keep those up to date. > > It's not user-visible, so I'm fine, but users should have a > possibility to know about supported chips in the Kconfig option. > > Assuming above is done deal, > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Yep, it's documented in Kconfig already. Actually I even added one missing chip to Kconfig in patch 4/9 (BMA222) :) Thanks! Stephan
