On Thu, Jun 10, 2021 at 03:50:25PM +0300, Andy Shevchenko wrote: > On Thu, Jun 10, 2021 at 3:24 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote: > > > > Right now all the device IDs are listed in seemingly random order, > > make this consistent by ordering those alphabetically. Also, order > > bmc150_accel_chip_info_tbl by chip ID for the same reason. > > Thanks! > My comments below, after addressing them, > Reviewed-by: Andy Shevchenko <andy.shevhcenko@xxxxxxxxx> > > ... > > > select BMC150_ACCEL_SPI if SPI > > help > > Say yes here to build support for the following Bosch accelerometers: > > - BMC150, BMI055, BMA250E, BMA222E, BMA255, BMA280. > > + BMA222, BMA222E, BMA250E, BMA255, BMA280, BMC150, BMI055. > > Thanks! > > > - This is a combo module with both accelerometer and magnetometer. > > > + BMC150 is a combo module with both accelerometer and magnetometer. > > BMC150 is only one from the list. Previous message applies to all > listed components, so is this not true anymore for the rest? > Or all the rest is not a combo? Please, clarify that in the commit > message, or if this is a wrong change, drop it. > I stumbled on that sentence when making the changes and it definitely does not apply to the BMA* variants. Those are accelerometer only. As far I can tell the prefix in the chip name says which kind of sensors are included, i.e. - BMC150: accelerometer + magnetometer - BMA*: only accelerometer I'm not familiar with BMI055 but funnily the datasheet suggests it's - BMI055: accelerometer + gyroscope So for BMI055 the previous message is wrong too. I guess I need to do yet another commit in v3 to make the Kconfig option more clear for all the sensor variants. :) Thanks! Stephan
