On Thu, Jun 10, 2021 at 01:29:26PM +0300, Andy Shevchenko wrote: > On Thu, Jun 10, 2021 at 12:56 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote: > > > > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. > > The current situation is very confusing: BMA254 is supported by the bma180 > > driver, but BMA255 is supported by the bmc150-accel driver. > > > > It turns out the bma180 and bmc150-accel drivers have quite some overlap, > > and BMA253/BMA254 would be a bit better supported in bmc150 > > (which has support for the motion trigger/interrupt). > > > > This series adds BMA253 support to bmc150-accel and also moves BMA254 > > over to bmc150, removing some unnecessary code from the bma180 driver. > > > > I asked Linus Walleij to test these patches on BMA254 a while ago > > and he suggested that I already add his Reviewed-by. > > I add > > > After addressing comments per patch 1, feel free to add my > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > to the series. > Thanks for the review! I think the re-ordering should be a separate commit to make the diff not too confusing. Is it fine for you if I send that as a follow-up patch? I already have two more patches that would conflict with the reordering, so it would be easier to include that in the next series. But I can also re-send the entire series with the extra patch if you prefer that, just let me know. :) > And I guess you can drop Laurentiu Palcu email because most of those > sensor drivers were done by an Intel team that is not at the company > anymore for a few years. > Oh yeah, got a lot of mails that it couldn't be delivered to Laurentiu. Oh well. Thanks, Stephan
