On Thu, Jun 10, 2021 at 12:56 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote: > > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. > The current situation is very confusing: BMA254 is supported by the bma180 > driver, but BMA255 is supported by the bmc150-accel driver. > > It turns out the bma180 and bmc150-accel drivers have quite some overlap, > and BMA253/BMA254 would be a bit better supported in bmc150 > (which has support for the motion trigger/interrupt). > > This series adds BMA253 support to bmc150-accel and also moves BMA254 > over to bmc150, removing some unnecessary code from the bma180 driver. > > I asked Linus Walleij to test these patches on BMA254 a while ago > and he suggested that I already add his Reviewed-by. I add After addressing comments per patch 1, feel free to add my Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> to the series. And I guess you can drop Laurentiu Palcu email because most of those sensor drivers were done by an Intel team that is not at the company anymore for a few years. > Stephan Gerhold (6): > iio: accel: bmc150: Drop misleading/duplicate chip identifiers > dt-bindings: iio: accel: bma255: Document bosch,bma253 > iio: accel: bmc150: Add device IDs for BMA253 > dt-bindings: iio: bma255: Allow multiple interrupts > dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schema > iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driver > > .../bindings/iio/accel/bosch,bma180.yaml | 3 +- > .../bindings/iio/accel/bosch,bma255.yaml | 9 +- > drivers/iio/accel/Kconfig | 6 +- > drivers/iio/accel/bma180.c | 91 +++---------------- > drivers/iio/accel/bmc150-accel-core.c | 36 ++------ > drivers/iio/accel/bmc150-accel-i2c.c | 34 ++++--- > drivers/iio/accel/bmc150-accel-spi.c | 31 ++++--- > drivers/iio/accel/bmc150-accel.h | 10 -- > 8 files changed, 67 insertions(+), 153 deletions(-) > > -- > 2.31.1 > -- With Best Regards, Andy Shevchenko
