On Mon, 2018-11-05 at 16:46 -0200, Giuliano Augusto Faulin Belinassi wrote: > Hello, > Could you help us figure out what must be added/changed into the > staging/iio/adc/ad7780.c to remove it from staiging? > > For instance, should we add an id field in ad7780_state struct that > represents ID1 and ID0 from the status bits (page 13 from datasheet)? > Or check the Status pattern bits PAT1, PAT0 for errors? Or something > else we can work on? > Hey, You don't need to check any patterns, that's already being done in the driver (see `pattern` & `pattern_mask` fields). And see function ad7780_postprocess_sample(). Though I will admit it would have been nicer if those patterns were generated from AD7780_PAT1 & AD7780_PAT0. So (if you want), you could update those pattern assignments with some macros ; for AD717x you may need to add AD7170_PAT2 (BIT(2)) I am noticing a small bug with the driver now (in ad7780_postprocess_sample()). The AD7780_GAIN bit-field (for AD778x) overlaps with AD7170_PAT2 (for AD717x). So, maybe you could add a field called `is_ad778x` in `ad7780_chip_info` and initialize it to true in the `ad7780_chip_info_tbl` for AD7780 & AD7781 ; and only perform the AD7780_GAIN check for these devices. According to the datasheets AD7170 & AD7171 have a fixed gain of 1. I would ignore the ID0 & ID1 fields ; those seem to overlap a bit between AD717x & AD778x. And they're not very useful in the driver. For AD778x you could also add support for the GAIN & FILTER pins via GPIOs, to control these settings. And then in the ad7780_postprocess_sample() function check if the GPIO settings (stored on a gpio_desc on ad7780_state) match the expected GAIN & FILTER bit settings ; if not return -EIO. All-in-all, the driver is almost ready to move out of staging (from my point of view). Not sure if anyone else has anything else to add. The bug should be fixed, and the rest is nice-to-have, but not necessarily a must (again, from my point of view) to keep it in staging. Also, generally: maybe do a comparative sweep between AD717x & AD778x datasheets and see if there's something left that's incorrect for any of these chips. Thanks Alex > Thank you. > On Tue, Oct 23, 2018 at 6:51 AM Jonathan Cameron > <jic23@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Mon, 22 Oct 2018 18:56:16 -0300 > > Giuliano Augusto Faulin Belinassi <giuliano.belinassi@xxxxxx> wrote: > > > > > Hello, > > > I have some questions about the ad7780 driver. > > > > > > * What is the val2 In the line 96 (*val2 = chan->scan_type.realbits > > > - 1;)? How it is used? Is it related to the 24-bits ADC precision? > > > > To understand that follow through what the code does when the type of a > > read_raw is IIO_VAL_FRACTIONAL_LOG2; > > > > > * Why there is a subtraction in the line 99 ( *val -= (1 << > > > (chan->scan_type.realbits - 1)); )? Is the *val initialized with 0? > > > Is > > > that related to the formula described in the DATA OUTPUT CODING, at > > > page 12? > > > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf > > > > Yeah, that -= is definitely wrong. Should just be an assignment to the > > negative value. This is telling userspace that the raw value should be > > offset by half of it's maximum range before applying the scale to get > > a reading in the IIO base units (here mV IIRC). > > > > > > > > With regards > > > > > > > > > On Thu, Oct 18, 2018 at 8:41 AM Giuliano Belinassi > > > <giuliano.belinassi@xxxxxxxxx> wrote: > > > > > > > > On 10/18, Ardelean, Alexandru wrote: > > > > > > > > Thank you for the reply :-). We will put effort into at least one > > > > driver to > > > > remove it from staging. > > > > > > > > > Hey, > > > > > > > > > > Thanks for the notification. > > > > > > > > > > Yes, all these 3 drivers should be moved out of staging. > > > > > > > > > > We were planning to start working on them (to move them out of > > > > > staging), > > > > > but priorities are shifting from one week to the other. > > > > > So, if you guys have the time and are willing to do it, please go > > > > > ahead, > > > > > and add me, michael.hennerich@xxxxxxxxxx and > > > > > stefan.popa@xxxxxxxxxx to the > > > > > CC when sending patches, and we will also take a look over your > > > > > patches. > > > > > > > > > > If you haven't taken a look already, feel free to also take a > > > > > look at our > > > > > wiki: > > > > > https://wiki.analog.com/resources/tools-software/linux-drivers-all > > > > > It's more technical for the SW side; it might help with some > > > > > general info. > > > > > And the datasheets should be available on the > > > > > analog.com/<product_id> > > > > > pages. > > > > > > > > > > > > > > > Thanks > > > > > Alex > > > > > > > > > > > > > > > On Wed, 2018-10-17 at 16:00 -0300, Giuliano Belinassi wrote: > > > > > > Hello, > > > > > > > > > > > > We are a student group and we want to contribute to the linux > > > > > > kernel. We > > > > > > are thinking in put effort to move a driver from staging to the > > > > > > main > > > > > > tree. > > > > > > We looked into three drivers: > > > > > > > > > > > > * adc/ad7780.c > > > > > > * adc/ad7816.c > > > > > > * impedance-analyzer/ad5933.c > > > > > > > > > > > > Are these drivers still being worked on? The last commit > > > > > > referencing > > > > > > these > > > > > > drivers were on march 2018, but they are still in staging since > > > > > > 2010. > > > > > > > > > > > > We already know that we have to convert from the old api to the > > > > > > new one. > > > > > > It is > > > > > > OK for us to work on this? Is there something else we can do? > > > > > > > > > > > > Thank you > > > > > > > > > > > > > > > > -- > > > > > You received this message because you are subscribed to the > > > > > Google Groups "Kernel USP" group. > > > > > To unsubscribe from this group and stop receiving emails from it, > > > > > send an email to kernel-usp+unsubscribe@xxxxxxxxxxxxxxxx. > > > > > To post to this group, send email to kernel-usp@xxxxxxxxxxxxxxxx. > > > > > To view this discussion on the web visit > > > > > https://groups.google.com/d/msgid/kernel-usp/d0fc5a236a82d03fdbe4d05eb27ff3bd3ac36958.camel%40analog.com > > > > > . > > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > -- > > > > You received this message because you are subscribed to the Google > > > > Groups "Kernel USP" group. > > > > To unsubscribe from this group and stop receiving emails from it, > > > > send an email to kernel-usp+unsubscribe@xxxxxxxxxxxxxxxx. > > > > To post to this group, send email to kernel-usp@xxxxxxxxxxxxxxxx. > > > > To view this discussion on the web visit > > > > https://groups.google.com/d/msgid/kernel-usp/20181018114145.amqff57holmecxpo%40smtp.gmail.com > > > > . > > > > For more options, visit https://groups.google.com/d/optout. > >
