Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On paź 01, 2018 14:51, Peter Meerwald-Stadler wrote:
> 
> > The checkpatch.pl tool detected coding style problem:
> > 
> >     CHECK: spaces preferred around that '-' (ctx:VxV)
> 
> oh no, not again
> please see e.g. https://lore.kernel.org/patchwork/patch/635994/
> for some discussion why this patch doesn't make sense

Oh...my mistake. Thank you for clarification. I should be more careful. Sorry!

> > in two files inside the adc directory. This patch will remove this
> > problem.
> > 
> > Signed-off-by: Slawomir Stepien <sst@xxxxxxxxx>
> > ---
> >  drivers/staging/iio/adc/ad7192.c  | 2 +-
> >  drivers/staging/iio/adc/ad7280a.c | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index acdbc07fd259..7c632cf1932b 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
> >  }
> >  
> 
> >  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> > -			     in_voltage-voltage_scale_available,
> > +			     in_voltage - voltage_scale_available,
> >  			     0444, ad7192_show_scale_available, NULL, 0);
> >  
> >  static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > index 58420dcb406d..a4b4f8678c56 100644
> > --- a/drivers/staging/iio/adc/ad7280a.c
> > +++ b/drivers/staging/iio/adc/ad7280a.c
> > @@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
> >  }
> >  
> >  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> > -		in_voltage-voltage_thresh_low_value,
> > +		in_voltage - voltage_thresh_low_value,
> >  		0644,
> >  		ad7280_read_channel_config,
> >  		ad7280_write_channel_config,
> >  		AD7280A_CELL_UNDERVOLTAGE);
> >  
> >  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> > -		in_voltage-voltage_thresh_high_value,
> > +		in_voltage - voltage_thresh_high_value,
> >  		0644,
> >  		ad7280_read_channel_config,
> >  		ad7280_write_channel_config,
> > 
> 

-- 
Slawomir Stepien



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux