Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote:
> The checkpatch.pl tool detected coding style problem:
> 
>     CHECK: spaces preferred around that '-' (ctx:VxV)
> 
> in two files inside the adc directory. This patch will remove this
> problem.
> 
> Signed-off-by: Slawomir Stepien <sst@xxxxxxxxx>
> ---
>  drivers/staging/iio/adc/ad7192.c  | 2 +-
>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index acdbc07fd259..7c632cf1932b 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
>  }
>  
>  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> -			     in_voltage-voltage_scale_available,
> +			     in_voltage - voltage_scale_available,
>  			     0444, ad7192_show_scale_available, NULL, 0);


This doesn't work.  That's not arithmatic, it's a string which is passed
to a macro.  It's an ugly macro, but it would take a lot of work to
change it at this point.

regards,
dan carpenter




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux