Re: [PATCH V2 00/45] IIO: Drop manual assignment of THIS_MODULE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 22 Aug 2017 22:19:29 +0100
Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 21 Aug 2017 13:38:22 +0100
> Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote:
> 
> > On Mon, 21 Aug 2017 09:42:01 +0200
> > Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> >   
> > > On 08/20/2017 05:13 PM, Jonathan Cameron wrote:    
> > > > 
> > > > Hi All,
> > > > 
> > > > If anyone has time to look over this set that would be great.
> > > > 
> > > > The ancient problem for maintainers, who is the reviewer of last
> > > > resort? Oh me... That doesn't work for my patches :)
> > > > 
> > > > No actual rush though - don't mind if these sit until next cycle -
> > > > would just get irritating if they sit until the one after and I have
> > > > to rebase them again...      
> > > 
> > > Sorry, for the delay. Whole series
> > > 
> > > Reviewed-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> > > 
> > > (I didn't actually review each of the individual '-.driver_module =
> > > THIS_MODULE', but I assume coccinelle did the right thing based on the
> > > spatch script).    
> > 
> > I did a couple of the new ones by hand but they look the same so should
> > be fine!
> > 
> > Thanks for review.
> > 
> > I'll drop the coccinelle patch I think as the field will have gone away
> > so it won't be possible to set it wrong in future.
> >   
> Series minus the coccinelle script applied to the togreg branch of iio.git
> and pushed out as testing.
> 

Testing picked up on the fact we have have an iio_dev in 
the mux subsystem that I'd forgotten about.

Peter, do you mind if I just pop in an additional patch such as:

diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
index 37ba007f8dca..92495d309193 100644
--- a/drivers/iio/multiplexer/iio-mux.c
+++ b/drivers/iio/multiplexer/iio-mux.c
@@ -173,7 +173,6 @@ static const struct iio_info mux_info = {
        .read_raw = mux_read_raw,
        .read_avail = mux_read_avail,
        .write_raw = mux_write_raw,
-       .driver_module = THIS_MODULE,
 };

Towards the end of this series?

Thanks,

Jonthan
> Thanks,
> 
> Jonathan
> 
> > Jonathan  
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html    
> >   
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux