From: Mark Rutland <mark.rutland@xxxxxxx>
Data: Wednesday, December 04, 2013 7:38 PM
>To: Duan Fugang-B38611
>Cc: jic23@xxxxxxxxxx; shawn.guo@xxxxxxxxxx; Li Frank-B20596;
>otavio@xxxxxxxxxxxxxxxx; pmeerw@xxxxxxxxxx; lars@xxxxxxxxxx; linux-
>iio@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v4 3/3] Documentation: add the binding file for Freescale
>vf610 ADC driver
>
>On Wed, Dec 04, 2013 at 10:00:03AM +0000, Fugang Duan wrote:
>> The patch adds the binding file for Freescale vf610 ADC driver.
>>
>> CC: Shawn Guo <shawn.guo@xxxxxxxxxx>
>> CC: Jonathan Cameron <jic23@xxxxxxxxxx>
>> CC: Mark Rutland <mark.rutland@xxxxxxx>
>> CC: Otavio Salvador <otavio@xxxxxxxxxxxxxxxx>
>> CC: Peter Meerwald <pmeerw@xxxxxxxxxx>
>> CC: Lars-Peter Clausen <lars@xxxxxxxxxx>
>> Signed-off-by: Fugang Duan <B38611@xxxxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/iio/adc/vf610-adc.txt | 42
>++++++++++++++++++++
>> 1 files changed, 42 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt
>> b/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt
>> new file mode 100644
>> index 0000000..32ae3bc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt
>> @@ -0,0 +1,42 @@
>> +Freescale vf610 Analog to Digital Converter bindings
>> +
>> +The devicetree bindings are for the new ADC driver written for
>> +vf610/i.MX6slx and upward SoCs from Freescale.
>> +
>> +Required properties:
>> +- compatible: Should contain "fsl,vf610-adc"
>> +- reg: Offset and length of the register set for the device
>> +- interrupts: Should contain the interrupt for the device
>> +- clocks: The clock is needed by the ADC controller, ADC clock source is ipg
>clock.
>
>The driver acquires the clock by name, and thus _requires_ clock-names.
>Please list the valid clock-names, and describe clocks property in terms of it.
>
>> +- vref-supply: The regulator supply ADC refrence voltage.
>> +
>> +Optional properties:
>> +- fsl,adc-io-pinctl: Enable field for the I/O port control of MCU pins used
>as analog inputs.
>> + Bit[23:0] correspond to 23 I/O ports, set the relative bit
>for pointed port.
>> +
>> +Example:
>> +adc0: adc@4003b000 {
>> + compatible = "fsl,vf610-adc";
>> + reg = <0x4003b000 0x1000>;
>> + interrupts = <0 53 0x04>;
>> + clocks = <&clks VF610_CLK_ADC0>;
>> + clock-names = "adc";
>> + status = "disabled";
>> +};
>> +
>> +adc1: adc@400bb000 {
>> + compatible = "fsl,vf610-adc";
>> + reg = <0x400bb000 0x1000>;
>> + interrupts = <0 54 0x04>;
>> + clocks = <&clks VF610_CLK_ADC1>;
>> + clock-names = "adc";
>> + status = "disabled";
>> +};
>
>This is missing vref-supply, and it's never overriden. If this is not a full
>example, remove it.
>
>> +
>> +&adc0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_adc0_ad5>;
>> + fsl,adc-io-pinctl = <0x20>;
>> + vref-supply = <®_vcc_3v3_mcu>;
>> + status = "okay";
>
>Why is adc0 split? The example should be simple.
>
Thanks for your review. I will simplify it.
Thanks,
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
