RE: [PATCH] IIO: TRIGGER: New sysfs based trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg KH wrote on 2011-02-02:
> On Wed, Feb 02, 2011 at 08:21:08PM +0100, michael.hennerich@xxxxxxxxxx
> wrote:
>> +static struct platform_driver iio_sysfs_trigger_driver = {
>> +    .driver = {
>> +            .name = "iio_sysfs_trigger",
>> +            .owner = THIS_MODULE,
>> +    },
>> +    .probe = iio_sysfs_trigger_probe,
>> +    .remove = __devexit_p(iio_sysfs_trigger_remove),
>> +};
>
> Why is this a platform device?  It doesn't seem to be platform
> specific at all, does it?

What else do you think it should be?
Construct driver on initcall, and use module parameters?
IMHO it is platform specific, since platform device bus allows me to register and run multiple instances.
Depending on the use case, which may vary from board/platform - multiple instances are required.

Like Mark indicated - in EMBEDDED if it doesn't belong to any other bus - it's likely a platform bus driver.

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux