Greg KH wrote on 2011-02-02: > On Wed, Feb 02, 2011 at 08:21:08PM +0100, michael.hennerich@xxxxxxxxxx > wrote: >> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> >> >> This patch adds a new trigger that can be invoked by writing the sysfs >> file: trigger_now. This approach can be valuable during automated >> testing or in situations, where other trigger methods are not >> applicable. For example no RTC or spare GPIOs. Last but not least we >> can allow user space applications to produce triggers. >> >> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> >> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> > > If you add a new sysfs file, you need to document it. I'll not take > this patch as-is because of that. Fair enough - I'll resubmit with the file added do the documentation. >> --- >> drivers/staging/iio/trigger/Kconfig | 6 ++ >> drivers/staging/iio/trigger/Makefile | 1 + >> drivers/staging/iio/trigger/iio-trig-sysfs.c | 108 >> ++++++++++++++++++++++++++ 3 files changed, 115 insertions(+), 0 >> deletions(-) create mode >> 100644 drivers/staging/iio/trigger/iio-trig-sysfs.c >> >> diff --git a/drivers/staging/iio/trigger/Kconfig >> b/drivers/staging/iio/trigger/Kconfig >> index d842a58..c185e47 100644 >> --- a/drivers/staging/iio/trigger/Kconfig >> +++ b/drivers/staging/iio/trigger/Kconfig >> @@ -18,4 +18,10 @@ config IIO_GPIO_TRIGGER >> help >> Provides support for using GPIO pins as IIO triggers. >> +config IIO_SYSFS_TRIGGER >> + tristate "SYSFS trigger" >> + depends on SYSFS >> + help >> + Provides support for using SYSFS entry as IIO triggers. > > Why would you ever want to not have this enabled? Why is it a config > option? And shouldn't it depend on the IIO subsystem? > > > >> + >> endif # IIO_TRIGGER >> diff --git a/drivers/staging/iio/trigger/Makefile >> b/drivers/staging/iio/trigger/Makefile >> index 10aeca5..504b9c0 100644 >> --- a/drivers/staging/iio/trigger/Makefile >> +++ b/drivers/staging/iio/trigger/Makefile >> @@ -4,3 +4,4 @@ >> >> obj-$(CONFIG_IIO_PERIODIC_RTC_TRIGGER) += iio-trig-periodic-rtc.o >> obj-$(CONFIG_IIO_GPIO_TRIGGER) += iio-trig-gpio.o >> +obj-$(CONFIG_IIO_SYSFS_TRIGGER) += iio-trig-sysfs.o >> diff --git a/drivers/staging/iio/trigger/iio-trig-sysfs.c >> b/drivers/staging/iio/trigger/iio-trig-sysfs.c >> new file mode 100644 >> index 0000000..3434f3c >> --- /dev/null >> +++ b/drivers/staging/iio/trigger/iio-trig-sysfs.c >> @@ -0,0 +1,108 @@ >> +/* >> + * Copyright 2011 Analog Devices Inc. >> + * >> + * Licensed under the GPL-2 or later. > > Are you sure you really mean "or later"? Seriously, do your lawyers > agree that this is what they want to have happen to this file? > >> + * >> + * iio-trig-sysfs.c > > Don't put the file name in the file itself, that's pointless :) > >> +MODULE_AUTHOR("Michael Hennerich >> +<hennerich@xxxxxxxxxxxxxxxxxxxx>"); >> +MODULE_DESCRIPTION("Sysfs based trigger for the iio subsystem"); >> +MODULE_LICENSE("GPL v2"); > > What is going to cause this module to be loaded in the system? Are > you relying on userspace to load it if it "knows" it is needed? > That's really not nice, we should trigger off of some type of hardware. > > thanks, > > greg k-h Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html