On Wed, Feb 02, 2011 at 07:50:01PM +0000, Mark Brown wrote: > On Wed, Feb 02, 2011 at 11:43:18AM -0800, Greg KH wrote: > > On Wed, Feb 02, 2011 at 08:21:08PM +0100, michael.hennerich@xxxxxxxxxx wrote: > > > > +static struct platform_driver iio_sysfs_trigger_driver = { > > > + .driver = { > > > + .name = "iio_sysfs_trigger", > > > + .owner = THIS_MODULE, > > > + }, > > > + .probe = iio_sysfs_trigger_probe, > > > + .remove = __devexit_p(iio_sysfs_trigger_remove), > > > +}; > > > Why is this a platform device? It doesn't seem to be platform specific > > at all, does it? > > Platform devices are used throughout the embedded kernel for virtual > devices Yes, but that doesn't mean they should be. > - the MFD subsystem is one of the most obvious examples here. Don't make a device a "platform" device unless it really is one. This one isn't one, it's a "virtual" device, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html