On 07/29/10 16:52, Randy Dunlap wrote: > On Wed, 28 Jul 2010 22:14:38 +0100 Jonathan Cameron wrote: > >> On 07/28/10 21:10, Randy Dunlap wrote: >>> On 07/28/10 12:07, Jonathan Cameron wrote: >>>> Hi Greg, >>>> >>>> Sorry about this lot. I clearly missed one big case when build testing >>>> the last series of patches I sent you. Evidently never built them without >>>> buffering enabled. >>>> >>>> Randy Dunlap found these 3 (posted to lkml in the thread, >>>> >>>> mmotm 2010-07-27-14-56 uploaded (staging/iio) >>>> >>>> I know of one remaining issue to do with some pointer arithmetic that won't >>>> work on 64 bit machines that I will try and get fixed shortly. >>> >>> Thanks. With these 3 patches applied, I still have this build warning: >>> >>> In file included from linux-next-20100728/drivers/staging/iio/accel/lis3l02dq_core.c:31: >>> linux-next-20100728/drivers/staging/iio/accel/../ring_sw.h:223: warning: 'struct iio_ring_access_funcs' declared inside parameter list >>> linux-next-20100728/drivers/staging/iio/accel/../ring_sw.h:223: warning: its scope is only this definition or declaration, which is probably not what you want >> Thanks, I missed that one. Shouldn't cause any actual problems >> (the function isn't actually called) but the warning is indicating >> that it is in the wrong place wrt to the ifdefs. I'll clear it up >> along with the pointer issue in the morning (and the silly lack >> of static in the 3rd patch that sparse indicated). >> > > With these 3 patches applied, on linux-next 20100729, I'm getting: > > ERROR: "iio_trigger_notify_done" [drivers/staging/iio/ring_sw.ko] undefined! Thanks again Randy. Gah. This must be worst patch series yet... Anyhow, new version of the fixes shortly... Jonathan > > config file is attached. > >>> >>> >>>> Jonathan Cameron (3): >>>> staging:iio: iio_sw_ring_helper_state - add dummy case for no buffer >>>> builds. >>>> staging:iio:lis3l02dq add a thresh_timestamp field to state for no >>>> ring case >>>> staging:iio:adis1350 add dummy ring functions for no ring build case >>>> >>>> drivers/staging/iio/accel/lis3l02dq.h | 2 ++ >>>> drivers/staging/iio/accel/lis3l02dq_core.c | 14 +++++++------- >>>> drivers/staging/iio/imu/adis16350.h | 8 ++++++++ >>>> drivers/staging/iio/ring_sw.h | 3 +++ >>>> 4 files changed, 20 insertions(+), 7 deletions(-) >>>> >>> >>> >> >> > > > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
