On 1/30/20 11:24 AM, Bartlomiej Zolnierkiewicz wrote: > > On 12/13/18 11:46 AM, Hannes Reinecke wrote: >> Hi all, > > Hi, > >> I got tired of always having to recompile the ATA drivers with ATA_DEBUG >> set so here's now a patchset of move every user of DPRINTK over to >> dynamic debugging, and drop ATA_DEBUG completely. >> >> As usual, comments and reviews are welcome. > > This patchset somehow slipped through the cracks which is > a shame because it seems to be a valuable contribution. > > I agree with the general approach but have some comments to > the individual patches (please see my other replies). > Whee! The work's not been lost! I've found myself to redo the patches occasionally, but then never resend them due to lack of reviews (and, by implication, lack of interest ...) Thanks for the review! Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer