On 12/13/18 11:47 AM, Hannes Reinecke wrote:
> Drop pointless DPRINTK calls around pci_register_driver() and move the
> remaining call over to dev_dbg().
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
> ---
> drivers/ata/ata_piix.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index 7ecb1322a514..f757ff8d0248 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -1362,7 +1362,8 @@ static void piix_init_pcs(struct ata_host *host,
> new_pcs = pcs | map_db->port_enable;
>
> if (new_pcs != pcs) {
> - DPRINTK("updating PCS from 0x%x to 0x%x\n", pcs, new_pcs);
> + dev_dbg(&pdev->dev,
> + "updating PCS from 0x%x to 0x%x\n", pcs, new_pcs);
Please preserve __func__ printing in the conversion.
> pci_write_config_word(pdev, ICH5_PCS, new_pcs);
> msleep(150);
> }
> @@ -1786,14 +1787,12 @@ static int __init piix_init(void)
> {
> int rc;
>
> - DPRINTK("pci_register_driver\n");
> rc = pci_register_driver(&piix_pci_driver);
> if (rc)
> return rc;
>
> in_module_init = 0;
>
> - DPRINTK("done\n");
> return 0;
> }
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
