On 12/13/18 11:46 AM, Hannes Reinecke wrote:
> Hi all,
Hi,
> I got tired of always having to recompile the ATA drivers with ATA_DEBUG
> set so here's now a patchset of move every user of DPRINTK over to
> dynamic debugging, and drop ATA_DEBUG completely.
>
> As usual, comments and reviews are welcome.
This patchset somehow slipped through the cracks which is
a shame because it seems to be a valuable contribution.
I agree with the general approach but have some comments to
the individual patches (please see my other replies).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Hannes Reinecke (24):
> libata: move ata_{port,link,dev}_dbg to dynamic debugging
> sata_nv: move DPRINTK to ata debugging
> sata_sx4: move DPRINTK to ata debugging
> sata_sil24: move DPRINTK to ata debugging
> sata_rcar: move DPRINTK to ata debugging
> sata_qstor: move DPRINTK to ata debugging
> pdc_adma: move DPRINTK to ata debugging
> ahci: move DPRINTK to ata debugging
> ahci_qorig: move DPRINTK to ata debugging
> pata_octeon_cf: move DPRINTK to ata debugging
> pata_sil680: move DPRINTK to ata debugging
> ata_piix: Remove DPRINTK usage
> libahci: move DPRINTK to ata debugging
> libata: move DPRINTK to ata debugging
> pata_pdc2027x: Replace PDPRINTK() with dynamic debugging
> sata_fsl: move DPRINTK to ata debugging
> sata_mv: replace DPRINTK with 'pci_dump' module parameter
> libata: add 'link' argument to ata_dev_classify()
> libata: Use ata_port_printk() in ata_dump_id()
> pata_pdc202xx_old: move DPRINTK to ata debugging
> libata: remove DPRINTK() macro
> ata: Remove remaining references to ATA_DEBUG
> libata: drop BPRINTK()
> libata.h: Whitespace cleanup
>
> drivers/ata/ahci.c | 10 ++---
> drivers/ata/ahci.h | 2 +-
> drivers/ata/ahci_qoriq.c | 4 +-
> drivers/ata/ata_piix.c | 5 +--
> drivers/ata/libahci.c | 25 ++++++-----
> drivers/ata/libata-core.c | 76 ++++++++++++++++++---------------
> drivers/ata/libata-eh.c | 26 ++++++------
> drivers/ata/libata-pmp.c | 12 +++---
> drivers/ata/libata-scsi.c | 26 ++++++------
> drivers/ata/libata-sff.c | 44 +++++++++----------
> drivers/ata/pata_octeon_cf.c | 13 +++---
> drivers/ata/pata_pdc2027x.c | 72 +++++++++++++------------------
> drivers/ata/pata_pdc202xx_old.c | 2 +-
> drivers/ata/pata_sil680.c | 2 +-
> drivers/ata/pdc_adma.c | 4 +-
> drivers/ata/sata_fsl.c | 94 ++++++++++++++++++++++-------------------
> drivers/ata/sata_inic162x.c | 2 +-
> drivers/ata/sata_mv.c | 71 ++++++++++++++++---------------
> drivers/ata/sata_nv.c | 22 +++++-----
> drivers/ata/sata_qstor.c | 5 ++-
> drivers/ata/sata_rcar.c | 10 ++---
> drivers/ata/sata_sil24.c | 6 +--
> drivers/ata/sata_sx4.c | 2 +-
> drivers/scsi/libsas/sas_ata.c | 3 +-
> include/linux/libata.h | 34 ++++++---------
> 25 files changed, 282 insertions(+), 290 deletions(-)
