On 11/05/2016 13:01, Måns Rullgård wrote: > Mason wrote: > >> Mans, did you intend to upstream your tangox-dma.c DMA driver? > > Yes, that's the idea, though I haven't yet updated it to work with > tango4. This SATA driver also needs a small addition to handle the DMA > glue. Now that the dust has settled a bit around these fixes, I can get > back to that. I may have an obsolete version of the driver, but I saw that you would sometimes call wmb() after writel(). I thought writel() includes an implicit write barrier? And that one uses writel_relaxed() if the barrier is not needed? Did I misunderstand? Somewhat related discussions: http://thread.gmane.org/gmane.linux.ports.arm.kernel/117626 http://billauer.co.il/blog/2014/08/wmb-rmb-mmiomb-effects/ Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html