On Wed, May 11, 2016 at 4:42 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > The dwc_460ex SATA driver has become available on non-powerpc architectures > and may cause randconfig build errors when CONFIG_DMADEVICES is not set > and SATA_DWC_OLD_DMA is enabled: > > warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES) > ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined! > ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined! > > This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we > cannot run into broken configurations. While it would also be > possible to build the driver with both CONFIG_DMADEVICES > and SATA_DWC_OLD_DMA disabled, that case is not useful because > there is no fallback to PIO mode when the DMA engine is not > usable. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel") Looks reasonable to me: Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > --- > drivers/ata/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 41b0725e58ad..e2dc4c045146 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -313,6 +313,7 @@ config ATA_PIIX > > config SATA_DWC > tristate "DesignWare Cores SATA support" > + depends on DMADEVICES > select GENERIC_PHY > help > This option enables support for the on-chip SATA controller of the > -- > 2.7.0 > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html