On Fri, 2016-01-22 at 11:13 +0000, Måns Rullgård wrote: > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > > On Wed, 2016-01-20 at 20:07 +0000, Måns Rullgård wrote: > > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes: > > In DWC_DEFAULT_CTLLO() can we do tab indentation for \ ? > > Is there a wrong indentation somewhere? I don't see it. My git diff shows this in particular: --- a/drivers/dma/dw/core.c +++ b/drivers/dma/dw/core.c @@ -45,10 +45,10 @@ DW_DMA_MSIZE_16; \ u8 _dmsize = _is_slave ? _sconfig->dst_maxburst : \ DW_DMA_MSIZE_16; \ - u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ? \ - _dwc->p_master : _dwc- >m_master; \ - u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ? \ - _dwc->p_master : _dwc- >m_master; \ + u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ? \ + _dwc->p_master : _dwc- >m_master; \ + u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ? \ + _dwc->p_master : _dwc- >m_master; \ Means in your case the ' \' is used, in mine — '\t\' at the end of lines. > Now the question: who do you prefer to submit the series (dw_dmac)? > > Me > > or you? > > > > In case you would like to do it (what I see in your dwc-sata branch > > today): > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > I'll fix the above, give your changes a review, and add my sign-off > before sending the series, today or during the weekend. OK. Just to be sure we are on the same page. I assume your dwc-sata branch as for submitting. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
