On Wed, Jan 20, 2016 at 9:46 PM, Måns Rullgård <mans@xxxxxxxxx> wrote: >>>> One comment still regarding to lli types. We can avoid warnings by >>>> using (__force u32) in macros. >>> >>> But that won't give the benefits of having the types checked. >> >> You mean if we access the lli->field directly? I didn't quite get what >> use case you are keeping in mind. > > Yes, accessing any of those fields directly with my patch gives a sparse > warning. It's situations like these those checks are intended for. > Defeating them seems foolish to me. Otherwise it makes that struct looks ugly. Why not union, though it still ugly, but less. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
