On Thu, 2016-01-07 at 18:32 +0000, Måns Rullgård wrote: > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > > > On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote: > > > > > So, Måns, Julian, I just have published my repository containing > > Måns' > > and my patches regarding dw_dmac and sata_dwc_460ex drivers here > > > > https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext > > I've picked out the relevant changes from your branch and made some > additional improvements. A few notes: > > - The __be32/__le32 typedefs for the DMA descriptor fields are > necessary > to avoid a million sparse warnings (and sparse is correct to warn). Hmm… Which version of sparse are you using? I always run builds with sparse enabled and didn't see anything. > - Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver > may > well be used on another big endian system some day. The Kconfig > logic > for selecting this option could perhaps be improved though. Maybe runtime chosen accessors will be better than ifdefs? I don't like the Kconfig option which limits application of the (compiled) driver. > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). > > Code here: > https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata Thanks for testing! -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
